[Bug 753019] Review Request: perl-Crypt-RC4-XS - Perl implementation of the RC4 encryption algorithm

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=753019

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2011-11-16 01:03:09 EST ---
Review:-

+ koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3518020
+ rpmlint on package gave
perl-Crypt-RC4-XS.src: W: spelling-error %description -l en_US keystream -> key
stream, key-stream, keystroke
perl-Crypt-RC4-XS.src: W: spelling-error %description -l en_US cryptosystems ->
cryptograms
perl-Crypt-RC4-XS.x86_64: W: spelling-error %description -l en_US keystream ->
key stream, key-stream, keystroke
perl-Crypt-RC4-XS.x86_64: W: spelling-error %description -l en_US cryptosystems
-> cryptograms
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
+ source match with upstream as (sha1sum)
ab829726c1398c37dd6fa2e356f5bb785f2020e8  Crypt-RC4-XS-0.02.tar.gz
ab829726c1398c37dd6fa2e356f5bb785f2020e8  ../SOURCES/Crypt-RC4-XS-0.02.tar.gz

+ make test gave
All tests successful.
Files=2, Tests=19,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.02 cusr  0.00
csys =  0.04 CPU)
+ Package: perl-Crypt-RC4-XS-0.02-1.fc17.x86_64
Provides: perl(Crypt::RC4::XS) = 0.02
Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.4)(64bit) perl(AutoLoader) perl(Exporter) perl(XSLoader)
perl(strict) perl(warnings) rtld(GNU_HASH)
+ Follows packaging guidelines

Suggestions:
1) you don't need following in Fedora now
%defattr(-,root,root,-)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.