[Bug 754137] Review Request: nagios-plugins-bdii - Nagios Probe for the BDII

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=754137

--- Comment #4 from Laurence.Field at cern.ch 2011-11-16 04:51:09 EST ---
Here is a new version

Spec URL: http://lfield.web.cern.ch/lfield/nagios-plugins-bdii.spec
SRPM URL: lfield.web.cern.ch/lfield/nagios-plugins-bdii-1.0.12-1.el5.src.rpm

Changes:

1) I have removed the use of buildroot for the compile and now remove the
buildroot before the install as I am also targeting EPEL5.

2) I have put the plugin in /usr/lib64/nagios/plugins/ and added this directory
to the package. I am now consistent with other nagios plugins.

rpm -ql nagios-plugins-ldap
/usr/lib64/nagios/plugins/check_ldap
/usr/lib64/nagios/plugins/check_ldaps


2.5) Having absolutely no documentation is odd. This is consistent with other
plugins (see above).

3)  I have changed Url to URL in the specfile.

4) Upstream has added a license header to the source resulting in a new
version.

5) BuildRequires is now openldap-devel%{?_isa}

6) Requires: openldap has been removed from the specfile.

7) The setting of CFLAGS has been removed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.