[Bug 749562] Review Request: comoonics-base-py - Comoonics minimum base libraries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=749562

Laurence.Field at cern.ch changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Laurence.Field at cern.ch

--- Comment #1 from Laurence.Field at cern.ch 2011-11-16 05:57:59 EST ---
I have had a quick look at this package to try to do an informal review as part
of my sponsorship process.

>From a visual check of the specfile I have found the following issues.

1) Url: should probably be URL: as it is more conventional and it's an acronym
after all.

2) The first line in the specfile is

%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print get_python_lib()")}

However, the from reading the python packaging guidelines
(http://fedoraproject.org/wiki/Packaging:Python) it suggests to me that it
should be the following is required.

%if 0%{?rhel} <= 5
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib())")}
%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
%endif

3) Again, from reading the python packaging guidelines it suggests that the
following should be used instead of BuildRequires: python-devel if targeting
python 2 and 3.

BuildRequires: python2-devel
BuildRequires: python3-devel

>From running rpmlint on the src package.

1) The default file attribute should be set.

comoonics-base-py.src:30: E: files-attr-not-set
comoonics-base-py.src:31: E: files-attr-not-set
comoonics-base-py.src:32: E: files-attr-not-set

Add %defattr(-,root,root) as the first line in the %files section

2) No cleaning of build root in the %install section

comoonics-base-py.src: W: no-cleaning-of-buildroot %install

Add rm -rf %{buildroot} as the first line in the %install section

3) No clean section.

comoonics-base-py.src: W: no-cleaning-of-buildroot %clean

Add to the spec file the following lines.

%clean
rm -rf %{buildroot}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.