[Bug 734410] Review Request: abootimg - tool for manipulating Android boot images

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=734410

--- Comment #3 from Yanko Kaneti <yaneti at declera.com> 2011-11-16 12:11:21 EST ---
Thanks for the review.

> abootimg.x86_64: W: spelling-error %description -l en_US Porject -> Project
> abootimg.src: W: spelling-error %description -l en_US Porject -> Project
> Spelling mistake in the specfile

Fixed.


> Need to specify a Group in the specfile

Not necessary. Group tag is basically deprecated from around F10..
Granted the guidelines simply do not mention it.


> abootimg.src:37: E: files-attr-not-set
> abootimg.src:38: E: files-attr-not-set
> abootimg.src:39: E: files-attr-not-set
> The default file attribute should be set.

Not necessary unless some file has explicitly wrong ones.
http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions


> abootimg.src: W: no-cleaning-of-buildroot %install
> No cleaning of build root in the %install section

Not necessary.
http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag


> abootimg.src: W: no-%clean-section
> abootimg.src: W: no-cleaning-of-buildroot %clean
> No clean section.

Not necessary. 
http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean



> [-] MUST: The sources used to build the package must match the upstream source,
> as provided in the spec URL.
> - Could not general the source from the specified commands

The instructions certainly work for me. I'll need more details on what actually
failed for you.


> [-] MUST: Each package must have a %clean section, which contains rm -rf
> %{buildroot} (or $RPM_BUILD_ROOT).
> - Missing

See the %clean guidelines mentioned above.


> [-] MUST: At the beginning of %install, each package MUST run rm -rf
> %{buildroot} (or $RPM_BUILD_ROOT).
> - Missing and submission suggests that RHEL 5 is targeted

I am not sure what makes you think the submission targets RHEL5



0.6-2.20110830gitff8e759
- Fixed a typo pointed by the first review.

Spec URL: http://declera.com/~yaneti/abootimg/abootimg.spec
SRPM URL:
http://declera.com/~yaneti/abootimg/abootimg-0.6-2.20110830gitff8e759.fc17.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.