[Bug 700354] Review Request: perl-Locale-Currency-Format - Perl functions for formatting monetary values

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700354

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+

--- Comment #2 from Parag AN(पराग) <panemade at gmail.com> 2011-11-17 01:23:59 EST ---
Review:-

+ koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3521246

+ rpmlint on rpms gave
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ Source match with upstream as (sha1sum)
6b1028c91b3038dc6d04ce62ba67ccb6af3900b5  Locale-Currency-Format-1.28.tar.gz
6b1028c91b3038dc6d04ce62ba67ccb6af3900b5 
../SOURCES/Locale-Currency-Format-1.28.tar.gz

+ make test
All tests successful.
Files=1, Tests=26,  0 wallclock secs ( 0.02 usr +  0.01 sys =  0.03 CPU)

+ Package: perl-Locale-Currency-Format-1.28-1.fc17.noarch
Provides: perl(Locale::Currency::Format) = 1.28
Requires: perl >= 0:5.006_00 perl(Exporter) perl(strict)

+ Follows packaging guidelines

Suggestions:
1) If building this on Fedora only then you don't need
  a) buidlroot
  b) cleaning of buildroot in %install
  c) %clean section
  d) defattr(-,root,root,-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.