[Bug 749756] Review Request: zita-at1 - autotuner for JACK

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=749756

--- Comment #5 from Julian Sikorski <belegdol at gmail.com> 2011-11-17 04:58:01 EST ---
I took a liberty of adding desktop-file-utils to move this forward:
* rpmlint output OK:

$ rpmlint zita-at1.spec /var/lib/mock/fedora-16-x86_64/result/*rpm
zita-at1.src: W: spelling-error Summary(en_US) autotuner -> auto tuner,
auto-tuner, autoimmune
zita-at1.src: W: spelling-error %description -l en_US autotuner -> auto tuner,
auto-tuner, autoimmune
zita-at1.x86_64: W: spelling-error Summary(en_US) autotuner -> auto tuner,
auto-tuner, autoimmune
zita-at1.x86_64: W: spelling-error %description -l en_US autotuner -> auto
tuner, auto-tuner, autoimmune
zita-at1.x86_64: W: no-manual-page-for-binary zita-at1
3 packages and 1 specfiles checked; 0 errors, 5 warnings.

* Naming guidelines followed
* spec file naming correct: zita-at1.spec
* Packaging guidelines
  - use of --ffast-math violates [1]
  - BR: desktop-file-utils is missing [2]
* Licensing is correct: GPLv2+
* License tag matches the actual license
* COPYING file is included in %doc
* spec file is written in American English
* spec file is legible
* source matches upstream: d901f378da09407b550c72b2607cc97f
zita-at1-0.2.3.tar.bz2
* package does not build
  - BR: desktop-file-utils is missing
* ExcludeArch: unable to test
* BuildRequires: desktop-file-utils is missing
* locales do not apply
* there are no shared libraries
* there are no copies of system libs bundled
* package is not relocatable
* directory ownership is correct
* there are no duplicate files
* permissions are correct
* macros consistency:
  - please replace zita-at1 in Source1 and Patch0 with %{name}
* package contains code
* documentation is not big enough to warrant a -doc subpackage
* there are no header files, static nor dynamic libraries
* there are no subpackages
* there are no libtool archives
* there is a desktop file correctly installed with desktop-file-install
* there are no overlapping ownerships
* filenames are UTF-8

Summary:
* use of --ffast-math violates [1]. Either remove it or provide rationale on
why is it needed.
* BR: desktop-file-utils is missing [2]
* please replace zita-at1 in Source1 and Patch0 with %{name}

Once these issues are resolved, I'll approve the package.

[1] https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags
[2]
https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.