[Bug 754554] Review Request: presence - Bi-directional audio/video connections
bugzilla at redhat.com
bugzilla at redhat.com
Thu Nov 17 14:35:17 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754554
Stanislav Ochotnicky <sochotni at redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sochotni at redhat.com
--- Comment #2 from Stanislav Ochotnicky <sochotni at redhat.com> 2011-11-17 09:35:16 EST ---
If you want to create tarball from git it's better to use "git archive" to do
it. Your "tar -cJvf presence-%{version}.tar.xz presence-%{version}" packs .git
directory as well.
Another thing: Upstream version is 0.4 not 0.4.1. Version numbers in Fedora
should match versions from upstream tarball. I know you are upstream, but it's
still better to be consistent.
License is also incorrect, COPYING file is LGPL 2.1, yet spec states GPLv2+.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list