[Bug 754749] Review Request: perl-Glib-Object-Introspection - Dynamically create Perl language bindings

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=754749

Trond H. Amundsen <t.h.amundsen at usit.uio.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.h.amundsen at usit.uio.no

--- Comment #1 from Trond H. Amundsen <t.h.amundsen at usit.uio.no> 2011-11-17 12:10:20 EST ---
A few comments and nitpicks:

1. According to the perl packaging guidelines[1] you should include a Requires
to the particular version of perl the module was built against:
   Requires:  perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))

2. The same guidelines also states that the package should own vendorarch and
exlude the auto dir:
   %{perl_vendorarch}/*
   %exclude %dir %{perl_vendorarch}/auto/

3. If you plan an EPEL branch, you need to add a %clean section, and for EPEL5
and below also a BuildRoot tag and manual cleaning of %{buildroot} in the
%install section. Just something to consider.

4. I prefer %{buildroot} and %{optflags} over $RPM_BUILD_ROOT and
$RPM_OPT_FLAGS, respectively, but that's just me :)

[1] http://fedoraproject.org/wiki/Packaging:Perl

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.