[Bug 683790] Review Request: rubygem-hoe-yard - A Hoe plug-in for generating YARD documentation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=683790

--- Comment #7 from Bohuslav Kabrda <bkabrda at redhat.com> 2011-11-18 01:55:50 EST ---
(In reply to comment #6)
> > - You don't need to specify BuildRoot tag, see [2]
> - I know, as there is still open possibility to have this for EPEL in future, I
> keep it there.

Ah, I see. All right.

> > - You don't need to use the "%defattr(-, root, root, -)" line, see [3]
> - Yes, I'm aware of that, however i prefer to keep it there
> 

Any reasons for this? If it is not necessary, I recommend putting it away.

> > - Consider moving documentation into a subpackage (except of README.rdoc, which contains licensing info and therefore should be left in the main package).
> - Documentation is too small to put it into subpackage, not worth of effort.
> 

Ok, this is not a blocker, but next time, consider using gem2rpm from package
rubygem-gem2rpm, which will generate a nice scaffold and you won't have to take
care of this yourself.

> > - rpmbuild complains about History.rdoc and Manifest.txt listed twice. To solve
> > it:
> > ** the package shouldn't own the whole %{gemdir}/gems/%{gemname}-%{version}/
> > directory (BTW you can use %{geminstdir} instead of it), but should rather own
> > %dir %{geminstdir}
> > ** when you do that, you will need to add every subdirectory and file in
> > %{geminstdir} to %files, but you will be able to avoid the complaints about
> > files listed twice
> - Could not reproduce, works for me correctly (rpmlint-1.3.2).

Actually, you don't have to use rpmlint (and you are correct, it doesn't show
this warning), it is written in build log, see my scratch build:

http://koji.fedoraproject.org/koji/getfile?taskID=3523114&name=build.log

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.