[Bug 754554] Review Request: presence - Bi-directional audio/video connections

bugzilla at redhat.com bugzilla at redhat.com
Fri Nov 18 10:45:11 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=754554

--- Comment #10 from Stanislav Ochotnicky <sochotni at redhat.com> 2011-11-18 05:45:10 EST ---

Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated



==== C/C++ ====
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Package is not relocatable.


==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at least
one supported architecture.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).(EPEL6 & Fedora < 13)
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains a properly installed %{name}.desktop using
desktop-file-install file if it is a GUI application.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[!]: MUST Package run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) and the
beginning of %install. (EPEL5)
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package meets the Packaging Guidelines.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generates any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[!]: MUST Package must own all directories that it creates.
/usr/share/presence is unowned

[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.

        rpmlint presence-0.4.4-1.fc17.src.rpm
       
================================================================================
        presence.src:9: W: macro-in-comment %{version}
        presence.src:10: W: macro-in-comment %{version}
        presence.src:10: W: macro-in-comment %{version}
        presence.src: W: invalid-url Source0: presence-0.4.4.tar.xz
        1 packages and 0 specfiles checked; 0 errors, 4 warnings.
       
================================================================================

        rpmlint presence-0.4.4-1.fc17.i686.rpm
       
================================================================================
        presence.i686: W: no-manual-page-for-binary presence
        1 packages and 0 specfiles checked; 0 errors, 1 warnings.
       
================================================================================

        rpmlint presence-debuginfo-0.4.4-1.fc17.i686.rpm
       
================================================================================
        1 packages and 0 specfiles checked; 0 errors, 0 warnings.
       
================================================================================
Well now that you generate tarball with a script, it would be best to
get rid of those macros in comments

[!]: MUST Sources used to build the package matches the upstream source, as
provided in the spec URL.
        presence-0.4.4.tar.xz :
          MD5SUM this package     : 7d3b9be502690752ee443e4434b657ee
          MD5SUM upstream package : upstream source not found

verified they match when regenerated
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[!]: SHOULD Package functions as described.

While I don't have a webcam in my pc, I'd assume the application shows icons in
bottom screen area. Those buttons work, but they have no icons so it's
impossible to navigate

[x]: SHOULD Package does not include license text files separate from upstream.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
architectures.
[-]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
files.
[x]: SHOULD Spec use %global instead of %define.

Issues:
[!]: MUST Package run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) and the
beginning of %install. (EPEL5)
 - just in case you want EPEL5 branch, then you'd need defattr back as well and
buildroot def. I guess not...
[!]: MUST Package must own all directories that it creates.
  /usr/share/presence is unowned
[!]: SHOULD Package functions as described.

While I don't have a webcam in my pc, I'd assume the application shows icons in
bottom screen area. Those buttons work, but they have no icons so it's
impossible to navigate. Perhaps some missing requires?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list