[Bug 754554] Review Request: presence - Bi-directional audio/video connections

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=754554

Stanislav Ochotnicky <sochotni at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #12 from Stanislav Ochotnicky <sochotni at redhat.com> 2011-11-18 08:04:19 EST ---
(In reply to comment #11)
> (In reply to comment #10)
> 
> > Issues:
> > [!]: MUST Package run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) and the
> > beginning of %install. (EPEL5)
> 
> Fixed.

Well this was really needed only for EPEL5, but it doesn't hurt :-)

> I suppose this was because of globbing, I added the dir explicitly.

OK now. Though the "%{_datadir}/presence/*" entry is now redundant :-)


> > [!]: SHOULD Package functions as described.
> > 
> > While I don't have a webcam in my pc, I'd assume the application shows icons in
> > bottom screen area. Those buttons work, but they have no icons so it's
> > impossible to navigate. Perhaps some missing requires?
> 
> Yes, I suppose you ain't running GNOME? :) I added a dependency on
> gnome-icon-theme and -symbolic this should solve this.
> And you'll need to be creative to test the software on a machine without a
> webcam :)

Well I can't seem to make it work in Xnest (segfaults), Xephyr (works, but it
has the same problem with icons) even though I already had those icons
installed. You are right I am not running Gnome, so my environment is a little
non-standard. It shouldn't matter though. I should be able to run any
application under any WM/DE. 

There was another weird thing when I tried to resize the window. It jumped to
maximum width (as in maxiumu allowed by my graphics gard - wider than my
monitor).

Normally I'd probably tell the packager to sort it out with upstream first, but
since you are the upstream I think you are in a perfect position to fix this
later on...That said:

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.