[Bug 749232] Review Request: nagios-plugins-lcgdm - nagios probes for DPM / LFC nodes

bugzilla at redhat.com bugzilla at redhat.com
Sat Nov 19 12:55:21 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=749232

--- Comment #10 from Ricardo Rocha <rocha.porto at gmail.com> 2011-11-19 07:55:19 EST ---
Hi again.

Changes as requested:
- removed debug_package nil
- nagios config goes into /etc/nagios
- pnp4nagios templates go into
/usr/share/nagios/html/pnp4nagios/templates.lcgdm 

Two reasons i think it might be better to keep our own pnp4nagios templates dir
(but now moved under the default path):
- according to http://docs.pnp4nagios.org/pnp-0.4/doc_complete (look for
update), they recommend not to put anything under templates.dist on danger of
being overwritten
- we could put them under templates, as suggested on the page, but some probes
have very generic names, there's a probability of clash with another package 

It's an additional config hassle, but maybe its better?

I've updated the package to the latest upstream released version (fixes above +
two new probes), removed unnecessary build deps. One last thing related to a
previous comment: /etc/nrpe.d is provided by nrpe, so i added it as a requires
instead of owning the dir.

New spec and src rpms:
Spec URL: http://rocha.web.cern.ch/rocha/fedora/nagios-plugins-lcgdm.spec
SRPM URL:
http://rocha.web.cern.ch/rocha/fedora/nagios-plugins-lcgdm-0.5.0-1.src.rpm

Koji builds:
https://koji.fedoraproject.org/koji/taskinfo?taskID=3525643 (5E)
https://koji.fedoraproject.org/koji/taskinfo?taskID=3525647 (6E)
https://koji.fedoraproject.org/koji/taskinfo?taskID=3525651 (F16)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list