[Bug 755141] gnome-system-log - A log viewer for GNOME

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=755141

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|fedora-review-              |fedora-review+

--- Comment #2 from Parag AN(पराग) <panemade at gmail.com> 2011-11-19 09:43:23 EST ---
Review:-

+ koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3525753

+ rpmlint on rpms gave
gnome-system-log.src:43: W: macro-in-comment %{name}
gnome-system-log.x86_64: E: incorrect-fsf-address
/usr/share/doc/gnome-system-log-3.3.1/COPYING
gnome-system-log.x86_64: E: incorrect-fsf-address
/usr/share/doc/gnome-system-log-3.3.1/COPYING.docs
2 packages and 0 specfiles checked; 2 errors, 1 warnings.

+ source matched with upstream as (sha1sum)
dda64fba12539787b439d61c2912f7119f327fd5  gnome-system-log-3.3.1.tar.xz
dda64fba12539787b439d61c2912f7119f327fd5 
../SOURCES/gnome-system-log-3.3.1.tar.xz

+ Follows packaging guidelines

Suggestions:
1) Fix the marco-in-comment warning in spec.


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.