[Bug 732215] Review Request: mined - Powerful Text Editor
bugzilla at redhat.com
bugzilla at redhat.com
Sat Nov 19 23:16:10 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=732215
Martin Gieseking <martin.gieseking at uos.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody at fedoraproject.org |martin.gieseking at uos.de
Flag| |fedora-review?
--- Comment #10 from Martin Gieseking <martin.gieseking at uos.de> 2011-11-19 18:16:09 EST ---
Hi Matthieu,
there are still a couple of things that need to be addressed:
- Add file ./usrshare/package_doc/README to the %docs because it contains the
information that mined is licensed under GPLv3.
Additionally, the developer(s) should add the license header to all source
files as requested by the GPL. This isn't a blocker, though.
- change the permissions of the spec file to 644 (see rpmlint output)
- the manpage and file CHANGES must be converted to UTF8 (without changing
the timestamps), e.g. like so (in %prep):
for f in CHANGES man/mined.1; do
iconv -f iso-8859-1 -t utf8 $f >$f.tmp && \
touch -r $f $f.tmp && \
mv $f.tmp $f
done
- Fedora's %optflags are not applied. To fix this, add OPT='%{optflags}' to
the make statement.
- In the .desktop file, remove the .xpm suffix from the icon filename (see
desktop-file-validate output below). The proper extension is detected
automatically.
- xmined, umined, and uterm need xterm to work properly. Thus, you should add
Require: xterm. However, I suggest to split the binaries that rely on X to
a subpackage, e.g. "xmined", so that mined can be used in plain text-mode
environments as well without the need to install the whole X stuff.
- The help function (F1) doesn't work because file mined.hlp is missing. It's
not a Windows help file as indicated by your comment in the spec.
Add it to the package, e.g. to folder /usr/share/mined/help/.
- The html documentation should go to /usr/share/doc/%{name}-%{version}.
Currently, it's located in /usr/share/mined/doc_user/
$ rpmlint *.rpm
mined.src: W: strange-permission mined.spec 0666L
mined.x86_64: W: file-not-utf8 /usr/share/doc/mined-2011.19/CHANGES
mined.x86_64: W: file-not-utf8 /usr/share/man/man1/mined.1.gz
3 packages and 0 specfiles checked; 0 errors, 3 warnings.
$ desktop-file-validate mined.desktop
mined.desktop: error: (will be fatal in the future): value "mined.xpm" for key
"Icon" in group "Desktop Entry" is an icon name with an extension, but there
should be no extension as described in the Icon Theme Specification if the
value is not an absolute path
---------------------------------
key:
[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum mined-2011.19.tar.gz*
89e7a316e0918b8d1c001871f6e1aefd mined-2011.19.tar.gz
89e7a316e0918b8d1c001871f6e1aefd mined-2011.19.tar.gz.upstream
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[X] MUST: When compiling C, C++, or Fortran files, %{optflags} must be applied.
- add OPT='%{optflags} to "make"
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[X] MUST: Permissions on files must be set properly.
- fix the permissions of the .spec file
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[+] MUST: Packages must NOT contain any .la libtool archives.
[+] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[+] MUST: .desktop filex must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[X] MUST: All filenames in rpm packages must be valid UTF-8.
- CHANGES and mined.1 are iso-8859-1
- convert them to UTF8 (with iconv)
EPEL <= 5 only:
[X] MUST: The spec file must contain a valid BuildRoot field.
[X] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot}.
[X] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot}.
[.] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
[.] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[+] SHOULD: Timestamps of files should be preserved.
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[X] SHOULD: The reviewer should test that the package functions as described.
- help doesn't work
[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself.
[+] SHOULD: Your package should contain man pages for binaries/scripts.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list