[Bug 754749] Review Request: perl-Glib-Object-Introspection - Dynamically create Perl language bindings

bugzilla at redhat.com bugzilla at redhat.com
Sun Nov 20 15:32:51 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=754749

--- Comment #4 from Emmanuel Seyman <emmanuel.seyman at club-internet.fr> 2011-11-20 10:32:50 EST ---
This package fails to build so I can't properly start review.

Daniel, you'll want to add a BuildRequires on perl-Glib-devel (Glib::MakeHelper
is needed during build and that's the package it's in). FTR, It's probably best
to test that your package builds, in mock and/or in a scratch koji build before
submitting it.

As Trond noted, you'll definitely want to include a MODULE_COMPAT Requires.

Is there a reason you're forcing LANG=en_US.UTF8 ? If so, it's recommended to
add a comment explaining why.

Note that the defattr line is no longer needed in Fedora-only packages (but
leaving it in isn't a blocker).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list