[Bug 755602] Review Request: json_diff - Generates diff between two JSON files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=755602

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2011-11-21 11:20:32 EST ---
Review:

+ koji scratch build (f17)
->http://koji.fedoraproject.org/koji/taskinfo?taskID=3529825

+ rpmlint on rpms gave
json_diff.src:28: W: macro-in-comment %_
json_diff.src:33: W: macro-in-comment %_
json_diff.src:33: W: macro-in-comment %{buildroot}
json_diff.noarch: W: no-manual-page-for-binary json_diff
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
==> Above is not a blocker but at least macro warning can be fixed using %%
instead %

- source match with upstream as (sha1sum)
  Ok I got confused here. upstream have latest today's commit with 0.9.0 tag
whereas packaged tarball is 0.9.1 version

+ rest looks fine

suggestions:
1) If building this on Fedora only then you don't need
  a) buidlroot
  b) cleaning of buildroot in %install
  c) %clean section
  d) defattr(-,root,root,-)

2) Python sitelib macro not needed now in Fedora

3) install command should preserve timestamp
http://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.