[Bug 678634] Review Request: Saaghar - A Cross-Platform Persian Poetry Software

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678634

--- Comment #6 from Jiri Popelka <jpopelka at redhat.com> 2011-11-21 12:05:38 EST ---
[OK] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces.
Saaghar.x86_64: E: incorrect-fsf-address /usr/share/doc/Saaghar-0.9.69/README
Saaghar.x86_64: W: no-manual-page-for-binary saaghar                            
Both this problems are task for upstream.

[OK] MUST: The package must be named according to the Package Naming
Guidelines.
[OK] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[OK] MUST: The package must meet the Packaging Guidelines.
Consider removing %defattr(-,root,root,-)
https://fedoraproject.org/wiki/Packaging/Guidelines#File_Permissions

Wouldn't it be better to use URL http://sourceforge.net/projects/saaghar/ ?
Because I'm not able to switch http://pojh.iblogger.org/saaghar/
to english (there's probably not such an option) and the sourceforge page
points to it anyway.

[OK] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
[OK] MUST: The License field in the package spec file must match the actual
license.
[OK] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[OK] MUST: The spec file must be written in American English.
[OK] MUST: The spec file for the package MUST be legible.
[OK] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL.
a72340b04c782f7f39ba12afe5688306  Saaghar-0.9.69.tar.gz
cedf5c41a75a122f94a14f78611f336c  Saaghar-data-59.90.07.xz

[OK] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[NA] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[OK] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines.
qt4-devel works ok, however correct package name is qt-devel

[NA] MUST: The spec file MUST handle locales properly.
[NA] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[NA] MUST: Packages must NOT bundle copies of system libraries.
[NA] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package.
[OK] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[OK] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[OK] MUST: Permissions on files must be set properly.
[OK] MUST: Each package must consistently use macros.
[OK] MUST: The package must contain code, or permissable content.
[NA] MUST: Large documentation files must go in a -doc subpackage.
[OK] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[NA] MUST: Header files must be in a -devel package.
[NA] MUST: Static libraries must be in a -static package.
[NA] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[NA] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency.
[NA] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[OK] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.
desktop-file-validate is OK in this case
[OK] MUST: Packages must not own files or directories already owned by other
packages.
[OK] MUST: All filenames in rpm packages must be valid UTF-8.

[OK] SHOULD: The reviewer should test that the package builds in mock.
[OK] SHOULD: The reviewer should test that the package functions as described.
A package should not segfault instead of running, for example.
[-] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
I think Saaghar-data should require base package, but it's probably not a
problem as it is (i.e. when base package requires -data subpackage).

[-] SHOULD: your package should contain man pages for binaries/scripts. If it
doesn't, work with upstream to add them where they make sense.
See the rpmlint warning above.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.