[Bug 755093] Review Request: mactel-boot - boot tools for Intel Apple hardware

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=755093

--- Comment #10 from Mads Kiilerich <mads at kiilerich.com> 2011-11-21 14:21:26 EST ---
It still doesn't work me as it is.

Do the boot.efi symlink work for you? For me it always starts OS/X even when
Fedora is chosen in the EFI boot menu. It works as expected when I replace the
symlink with a real copy of grub.efi and bless it.

(Or could the /EFI/redhat/grub.efi be blessed in place and boot.efi just be a
place holder?)

I am no big fan of the dependency to redhat-lsb. LSB compliance and all the
dependencies should be optional. Very few packages depend on redhat-lsb - there
is for example nothing in a standard installation with gnome-desktop that does.
Most desktop machines do for example not want to have an MTA installed.

I guess the package should own the whole System/Library/CoreServices path and
remove it when the package is removed. OS/X will also create .disk_label and
.disk_label.contentDetails when the Startup Disk is chosen - I guess they
should be ghost (or explicitly removed) too so the directory can be removed.

Not that I like the automatic blessing, but don't you need a bless in
mactel-boot %post too to cover the case where grub2-efi already has been
installed?

The copyright "Red Hat <mjg at redhat.com>" looks a bit strange - is that
intentional?

Finally a couple of very minor comments:

It seems a bit strange that bless takes both the mount point and the path to
the boot loader file which must be below the same mount point. Somebody will
mess that up one day and make them point to different file systems. Wouldn't it
be simpler to find the hfs device from the boot loader stats?

mnt_new_table is leaking ... It doesn't matter and is off topic for a review,
but ...

There is a superfluous ';' after 'ln -s'.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.