[Bug 755275] Review Request: CSSLint - Detecting potential problems in CSS code
bugzilla at redhat.com
bugzilla at redhat.com
Tue Nov 22 11:47:57 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755275
--- Comment #3 from Parag AN(पराग) <panemade at gmail.com> 2011-11-22 06:47:56 EST ---
eview:
+ koji scratch build ->
http://koji.fedoraproject.org/koji/taskinfo?taskID=3529016
+ rpmlint on rpms gave
csslint.src: W: spelling-error %description -l en_US pluggable -> plug gable,
plug-gable, plugged
csslint.src: W: strange-permission csslint.sh 0755L
csslint.noarch: W: spelling-error %description -l en_US pluggable -> plug
gable, plug-gable, plugged
csslint.noarch: W: no-manual-page-for-binary csslint
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
+ source match with upstream as (sha1sum)
d6314b6253922032d8e3c4520b446a9f20ea6578 master
d6314b6253922032d8e3c4520b446a9f20ea6578
../SOURCES/stubbornella-csslint-v0.8.1-13-g2ec2ebb.tar.gz
Suggestions:
1) If building this on Fedora only then you don't need
a) buildroot
b) %clean section
c) defattr(-,root,root,-)
2) I see newer commits are already in upstream. Try to ask upstream to either
release a tarball or create a tag for 0.8.5
also if you are packaging snapshots then see
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list