[Bug 754094] Review Request: restauth - Web-service providing shared authentication, authorization and preferences

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=754094

--- Comment #3 from Jan Kaluža <jkaluza at redhat.com> 2011-11-22 07:43:49 EST ---
Fixed spec file and srpm:

Spec URL: http://jkaluza.fedorapeople.org/restauth.spec
SRPM URL: http://jkaluza.fedorapeople.org/restauth-0.5.2-2.fc16.src.rpm

> restauth.noarch: W: conffile-without-noreplace-flag
> /etc/restauth/localsettings.py
>   The noreplace flag would be probably worth here.

Added.

> restauth.noarch: E: zero-length
> /usr/lib/python2.7/site-packages/RestAuth/common/models.py
> restauth.noarch: E: zero-length
> /usr/lib/python2.7/site-packages/RestAuth/common/urls.py
>   Empty files shouldn't be packages unless there is special need for this. It
> would be good to forward this to upstream.

I've added comment to those files, so they should not be empty anymore. Those
files are needed there, because Django autodetects Django application if those
files are present. Upstream will put license there and comment similar to one I
used.

> restauth.noarch: E: non-readable /etc/restauth/localsettings.py 0640L
>   Probably OK to hide the DB secrets.

Yes, that's why those permissions are set.

> restauth.noarch: W: no-manual-page-for-binary restauth-group
> restauth.noarch: W: no-manual-page-for-binary restauth-import
> restauth.noarch: W: no-manual-page-for-binary restauth-service
> restauth.noarch: W: no-manual-page-for-binary restauth-manage
> restauth.noarch: W: no-manual-page-for-binary restauth-user

I included manpages from doc/ directory. According to upstream restuath-manage
manpage is not finished yet and it's in TODO.

>   Maybe missing version requirement for python-restauth-common.

It should not be needed to depend on particular python-restauth-common version
according to upstream.

> [!] BuildRequires are correct.
>   I cannot find the python-setuptools-devel in rawhide.
>   Is the python-setuptools really needed? It seems to build OK without it.

Fixed as with python-restauth-common package.

> [NO] Spec file has consistant macro usage.
>   Please use %{optflags} instead of $RPM_OPT_FLAGS or $RPM_BUILD_ROOT instead
> of %{buildroot}.

Fixed.

> Shouldn't you go with brp-python-bytecompile script and only remove the
> /etc/restauth/localsettings.pyo and /etc/restauth/localsettings.pyc before
> packaging?

It's not possible, pyc and pyo are generated after %install section. There's no
way to remove those files.

> It would be good to build and package the man pages. There are also several
> docs, that could be useful for end users, please consider packaging them.

Added restauth-doc package. Man pages are included too.

> What about the Python3? Is this supported? Upstream states Python 2.6 or later.

According to upstream "restauth" itself works only with python-2.x because of
Django, which does not support python-3.x so far...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.