[Bug 755358] Review Request: jcal - Unix cal-like interface to libjalali

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=755358

--- Comment #1 from Jiri Popelka <jpopelka at redhat.com> 2011-11-22 09:33:02 EST ---
Package Review
==============

! = Problem

[OK] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces.

There are some false-positives.

[OK] MUST: The package must be named according to the Package Naming
Guidelines.
[OK] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[OK] MUST: The package must meet the Packaging Guidelines.
[OK] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[OK] MUST: The License field in the package spec file must match the actual
license.
[OK] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[OK] MUST: The spec file must be written in American English.
[OK] MUST: The spec file for the package MUST be legible.
[OK] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL.

jcal-0.4.1.tar.gz: d4f94ee612494cd0ab0cf1f537aaa33b

[OK] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[NA] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[!] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines.

Few are missing
BuildRequires: autoconf
BuildRequires: automake
BuildRequires: libtool

[NA] MUST: The spec file MUST handle locales properly.
[OK] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[OK] MUST: Packages must NOT bundle copies of system libraries.
[NA] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review.
[NA] MUST: A package must own all directories that it creates.
[OK] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[OK] MUST: Permissions on files must be set properly.
[OK] MUST: Each package must consistently use macros.
[OK] MUST: The package must contain code, or permissable content.
[NA] MUST: Large documentation files must go in a -doc subpackage.
[OK] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[OK] MUST: Header files must be in a -devel package.
[NA] MUST: Static libraries must be in a -static package.
[OK] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[OK] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version}-%{release}
[OK] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[NA] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.
[OK] MUST: Packages must not own files or directories already owned by other
packages.
[OK] MUST: All filenames in rpm packages must be valid UTF-8.

[NA] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[!] SHOULD: The reviewer should test that the package builds in mock.

Please add the above mentioned BuildRequires.

[OK] SHOULD: The reviewer should test that the package functions as described.
A package should not segfault instead of running, for example.
[NA] SHOULD: If scriptlets are used, those scriptlets must be sane.
[OK] SHOULD: your package should contain man pages for binaries/scripts.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.