[Bug 697247] Review Request: gsmartcontrol - Graphical user interface for smartctl

bugzilla at redhat.com bugzilla at redhat.com
Tue Nov 22 21:55:33 UTC 2011

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
             Status|NEW                         |ASSIGNED
                 CC|                            |martin.gieseking at uos.de
         AssignedTo|nobody at fedoraproject.org    |martin.gieseking at uos.de
               Flag|                            |fedora-review?

--- Comment #5 from Martin Gieseking <martin.gieseking at uos.de> 2011-11-22 16:55:30 EST ---
Eric, here's the formal review of your package. There are only a few things
that need to be addressed (some are optional):

- please add parentheses around "GPLv2 or GPLv3" in the License field

- add the scriptlets required to update the icon cache:

- You can drop --prefix=%{_prefix} from %configure. It's already part of the 
  %configure macro.

- Add a second percent sign to #%PAM-1.0 to prevent a potential macro 
  expansion in the heredoc and to make rpmlint happy.

- The image files in %{_datadir}/%{name}/ are added twice in %files. Either 
  prefix %{_datadir}/%{name} with "%dir" or drop the two lines 
  %{_datadir}/%{name}/icon_cddvd.png and %{_datadir}/%{name}/icon_hdd.png.

- Maybe you want to replace the icon/hicolor lines by a single one:

- I suggest to move all the docs to %{_defaultdocdir}/%{name}-%{version}/ 
  instead of providing two doc dirs (versioned and unversioned).

$ rpmlint ./gsmartcontrol-*.rpm
gsmartcontrol.src: W: spelling-error Summary(en_US) smartctl -> smarts
gsmartcontrol.src: W: spelling-error %description -l en_US smartctl -> smarts
gsmartcontrol.src: W: spelling-error %description -l en_US smartmontools ->
gsmartcontrol.src:54: W: macro-in-comment %PAM
gsmartcontrol.x86_64: W: spelling-error Summary(en_US) smartctl -> smarts
gsmartcontrol.x86_64: W: spelling-error %description -l en_US smartctl ->
3 packages and 0 specfiles checked; 0 errors, 6 warnings.

The spelling errors are false positive.


[+] OK
[.] OK, not applicable
[X] needs work

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
[+] MUST: The License field in the package spec file must match the actual
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
    $ md5sum gsmartcontrol-0.8.6.tar.bz2*
    d2ac685e2e73b05f7ba74c93623af739  gsmartcontrol-0.8.6.tar.bz2
    d2ac685e2e73b05f7ba74c93623af739  gsmartcontrol-0.8.6.tar.bz2.upstream

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[+] MUST: When compiling C, C++, or Fortran files, %{optflags} must be applied.
[.] MUST: The spec file MUST handle locales properly.
[X] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates. 
[X] MUST: A Fedora package must not list a file more than once in %files.
    - the image files in %{_datadir}/%{name}/ are added twice

[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
[+] MUST: Packages must NOT contain any .la libtool archives.
[+] MUST: Packages containing GUI applications must include a %{name}.desktop
[+] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
[+] MUST: All filenames in rpm packages must be valid UTF-8.

EPEL <= 5 only:
[X] MUST: The spec file must contain a valid BuildRoot field.
[X] MUST: At the beginning of %install, each package MUST run rm -rf
[X] MUST: Each package must have a %clean section, which contains rm -rf
[.] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'

[.] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The reviewer should test that the package functions as described.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[+] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself.
[+] SHOULD: Your package should contain man pages for binaries/scripts.

Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

More information about the package-review mailing list