[Bug 754975] Review Request: pion-net - Pion Network Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=754975

--- Comment #3 from Michael Schwendt <mschwendt at gmail.com> 2011-11-22 17:33:58 EST ---
* F-16 and F-15 builds complete for both x86_64 and i686.


* HTML documentation is also included in the base package. This is because the
%doc macro for the base package installs the files in %_docdir/%name-%version,
which is exactly the path you use in the -doc subpackage. In the same way, the
-doc subpkg duplicates the %doc files from the base pkg %files list.


* -devel package is missing dependencies. In the C++ headers I see references
to Boost headers, OpenSSL, log4cpp. It's likely one cannot include pion-net
headers before installing missing -devel packages.


* The pkg-config file is broken in several ways:
 - on x86_64, it includes a hardcoded -L/usr/lib
 - its Libs definition duplicates the linker args that have been used to link
pion-net itself, not what is necessary to link with pion-net
 - the Cflags line needs a second look, in particular where the hardcoded
BOOST_FILESYSTEM_VERSION definition comes from (version 2 is deprecated)
 - $datarootdir and $datadir are undefined/unexpanded


* Source doesn't use Fedora's global compiler %optflags.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.