[Bug 749562] Review Request: comoonics-base-py - Comoonics minimum base libraries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=749562

--- Comment #3 from Tom "spot" Callaway <tcallawa at redhat.com> 2011-11-23 15:26:41 EST ---
Lawrence, thanks for the review. Please note the following:

* It is no longer necessary to have an explicit %clean section simply to rm -rf
%{buildroot}. This is the default in all active Fedora releases.

* It is no longer necessary to explicitly rm -rf %{buildroot} as the first line
of %install, this is the default in all active Fedora releases.

* It is no longer necessary to explicitly state %defattr(-,root,root,-) in each
%files section, this is the default in all active Fedora releases.

* I have no intention of trying to support Python3 with this package at this
time.

* It is not necessary to have a definition for python_sitearch for a noarch
python package. In fact, it isn't really necessary to have either definition in
the spec as they are set by default in all active Fedora releases.

I wonder if you were doing this on a RHEL system, since rpmlint on current
Fedora releases (14+) shouldn't have thrown these warnings/errors.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.