[Bug 756046] Review Request: udisks2 - Disk Manager
bugzilla at redhat.com
bugzilla at redhat.com
Thu Nov 24 04:45:56 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=756046
--- Comment #1 from Matthias Clasen <mclasen at redhat.com> 2011-11-23 23:45:55 EST ---
You should probably refer to 'udisks2' in the %description of the main package,
as well as the subpackage descriptions. Or maybe just add 'This package
contains version 2 of udisks.' for the main package.
%defattr(-,root,root,-) is no longer needed
There have been requests before to move the bash completion to
/etc/bash-completion.d (https://bugzilla.redhat.com/show_bug.cgi?id=584569).
Something to consider, maybe.
Other than that, the spec file looks fine at first glance. Will do a formal
review soon.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list