[Bug 756636] Review Request: gnome-screenshot - A screenshot utility for GNOME

bugzilla at redhat.com bugzilla at redhat.com
Thu Nov 24 10:16:59 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=756636

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
            Summary|gnome-screenshot - A        |Review Request:
                   |screenshot utility for      |gnome-screenshot - A
                   |GNOME                       |screenshot utility for
                   |                            |GNOME
               Flag|                            |fedora-review+

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2011-11-24 05:16:59 EST ---
Review:-

+ koji scratch build
->http://koji.fedoraproject.org/koji/taskinfo?taskID=3537183

+ rpmlint on rpms gave
gnome-screenshot.src:35: W: macro-in-comment %{_datadir}
gnome-screenshot.x86_64: W: obsolete-not-provided gnome-utils
gnome-screenshot.x86_64: E: incorrect-fsf-address
/usr/share/doc/gnome-screenshot-3.3.1/COPYING
gnome-screenshot.x86_64: E: invalid-desktopfile
/usr/share/applications/gnome-screenshot.desktop file contains group "Screen
Shortcut Group", but groups extending the format should start with "X-"
gnome-screenshot.x86_64: E: invalid-desktopfile
/usr/share/applications/gnome-screenshot.desktop file contains group "Window
Shortcut Group", but groups extending the format should start with "X-"
2 packages and 0 specfiles checked; 3 errors, 2 warnings.

+ source verified with upstream as (sha1sum)
734ecd3ee4f2ccbd463754ec5b28b54fcd54c4c3  gnome-screenshot-3.3.1.tar.xz
734ecd3ee4f2ccbd463754ec5b28b54fcd54c4c3 
../SOURCES/gnome-screenshot-3.3.1.tar.xz

+ follows packaging guidelines.

Suggestions:
1) you can fix the macro-in-comment rpmlint warning using %% instead of %

2) also you can ask upstream to update fsf address.

3) Has the desktop issue already reported in upstream?

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list