[Bug 721174] Review Request: cryptominisat - SAT solver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=721174

--- Comment #6 from Jerry James <loganjerry at gmail.com> 2011-11-24 15:55:30 EST ---
Well, no, it isn't really okay.  I'll talk to upstream about it.  Here's a
catalog of places where exit() is called:
- Solver/DimacsParser.cpp: if there is a parse error
- Solver/ClauseAllocator.cpp: if a memory allocation fails
- Solver/Solver.cpp: if it is asked to solve a problem that is too large
- Solver/SolverMisc.cpp: if output files cannot be opened

All of those should really either throw exceptions or return error values, so
the calling application can cope.  What would you like me to do: import and
work with upstream on the side, or wait for upstream to address this issue
before importing?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.