[Bug 757355] Review Request: telepathy-kde-contact-applet - Plasma applet for managing your Telepathy contacts

bugzilla at redhat.com bugzilla at redhat.com
Sat Nov 26 17:40:28 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=757355

nucleo <alekcejk at googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alekcejk at googlemail.com

--- Comment #1 from nucleo <alekcejk at googlemail.com> 2011-11-26 12:40:28 EST ---
"BuildRequires: desktop-file-utils" is not needed because .desktop file
installed in %{_kde4_datadir}/kde4/services/.

"%{?_kde4_version:Requires: kdelibs4%{?_isa} >= %{_kde4_version}}" can be
added.

And looks like "BuildRequires: telepathy-qt4-devel" missed.

Most of code is LGPLv2+ but config.cpp, config.h, contact-wrapper.cpp,
contact-wrapper.h, telepathy-contact.cpp, telepathy-contact.h is GPLv2+ - maybe
this is mistake?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list