[Bug 757290] Review Request: unicode-ucd - Unicode Character Database

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=757290

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #2 from Parag AN(पराग) <panemade at gmail.com> 2011-11-27 22:31:15 EST ---
Review:

+ koji scratch(f16) build ->
http://koji.fedoraproject.org/koji/taskinfo?taskID=3545268

+ rpmlint on rpms gave
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ source verified with upstream as (sha1sum)
d83d2bb7c4d34221cd9eaf53bfa730391ca9d135  UCD.zip
d83d2bb7c4d34221cd9eaf53bfa730391ca9d135  ../SOURCES/UCD.zip

+ follows packaging guidelines.


Suggestions:
1) I see duplication of copyright.html file at places
/usr/share/unicode/ucd/copyright.html
and
/usr/share/doc/unicode-ucd-6.0.0/copyright.html

I think you need to manually remove that file in %install.

2) unzip is already in minimal build environment so no need to BR: it in spec.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.