[Bug 700344] Review Request: perl-Authen-CAS-Client - Interface for authentication via JA-SIG's Central Authentication Service

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=700344

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #7 from Parag AN(पराग) <panemade at gmail.com> 2011-11-28 02:22:59 EST ---
Review:-

+ koji scratch build ->
http://koji.fedoraproject.org/koji/taskinfo?taskID=3545434

+ rpmlint on rpms gave
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ source verified with upstream as  (sha1sum)
fb13f4789a49df20769a27474b2e9174237b4d15  Authen-CAS-Client-0.05.tar.gz
fb13f4789a49df20769a27474b2e9174237b4d15 
../SOURCES/Authen-CAS-Client-0.05.tar.gz

+ make test gave
All tests successful.
Files=6, Tests=204,  1 wallclock secs ( 0.05 usr  0.01 sys +  0.47 cusr  0.05
csys =  0.58 CPU)

+ Package: perl-Authen-CAS-Client-0.05-2.fc17.noarch
Provides: perl(Authen::CAS::Client) = 0.05 perl(Authen::CAS::Client::Response)
= 0.03 perl(Authen::CAS::Client::Response::AuthFailure)
perl(Authen::CAS::Client::Response::AuthSuccess)
perl(Authen::CAS::Client::Response::Error)
perl(Authen::CAS::Client::Response::Failure)
perl(Authen::CAS::Client::Response::ProxyFailure)
perl(Authen::CAS::Client::Response::ProxySuccess)
perl(Authen::CAS::Client::Response::Success)

Requires: perl >= 0:5.006_001 perl(Authen::CAS::Client::Response)
perl(Authen::CAS::Client::Response::Failure)
perl(Authen::CAS::Client::Response::Success) perl(LWP::UserAgent) perl(URI)
perl(URI::QueryParam) perl(XML::LibXML) perl(base) perl(strict) perl(warnings)

+ rest follows packaging guidelines

Suggestions:
1) you don't need following in spec
BuildRequires:  perl >= 1:5.6.1

2) Remove ">=0.00" from all the BuildRequires: lines. you don't need them.


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.