[Bug 701801] Review Request: ast - A Library for Handling World Coordinate Systems in Astronomy

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=701801

--- Comment #5 from Sergio Pascual <sergio.pasra at gmail.com> 2011-11-28 05:02:23 EST ---
These are blockers, after fixing them the package should be ok.

License
------- 
* There are some files proj.c proj.h wcsmath.h wcstrig.c wcstrig.h (from an old
version of wcslib) under LGPLv2+. So the license tag should be: GPLv2+ and
LGPLv2+
* The FSF address is wrong. You should report it upstream 

Libraries
---------
* In the installed package there are some pgplot related libraries. As pgplot
is not free and can't be distributed by Fedora, I suggest to remove the
libraries

/usr/lib64/libast_pgplot3d.so
/usr/lib64/libast_pgplot3d.so.0
/usr/lib64/libast_pgplot3d.so.0.0.0
/usr/lib64/libast_pgplot.so
/usr/lib64/libast_pgplot.so.0
/usr/lib64/libast_pgplot.so.0.0.0

Documentation
------------- 
* rpmlint complains about hidden directories and empty files. They should be
removed.

ast-doc.x86_64: W: hidden-file-or-dir
/usr/share/doc/ast/sun210.htx/.star2html-init
ast-doc.x86_64: E: zero-length /usr/share/doc/ast/sun210.htx/star2html.sty
ast-doc.x86_64: E: zero-length /usr/share/doc/ast/sun211.htx/star2html.sty
ast-doc.x86_64: W: hidden-file-or-dir
/usr/share/doc/ast/sun211.htx/.star2html-init

* Tex files are included. They should be removed unless they are needed for
something.

* In the spec, you create a /usr/share/doc/ast directory and move there the
documentation installed. But the name of the directory is incorrect. Everything
in docdir is named "package-version", in this case ast-doc-5.7.2

I would let rpm do its job and grab the docs from the source dir

%files doc
%doc sun210.htx sun210.ps sun211.htx sun211.ps

Other recommendations, not blockers

* The following macros are not needed anymore, so you can remove them safely
from the specfile:
BuildRoot, %clean and %defattr

* If you are willing and have time, you can try to educate upstream about:
 - its weird versioning scheme
 - linking to wcstools instead of pasting wcstools files in the code
 - using pkgconfig instead of home-made solutions
 - creating pgplot libraries only if pgplot is present

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.