[Bug 754698] Review Request: idjc - DJ application with streaming capabilities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=754698

--- Comment #7 from Ismael Olea <ismael at olea.org> 2011-11-28 07:42:14 EST ---
(In reply to comment #6)
> You are right about this. I added a more detailed description. I don't see
> necessary to explicitly point all the supported formats, as it actual supports
> almost every free major audio format.

Description is now fine.

> 
> > * accordingly, IMHO would be appropiated to add a README.Fedora with the format support information explained
> 
> I think that upstream documentation already covers that.

Let me disagree on that. But my point is about to explicit the relevant
differences on supported formats here. Just a very brief informational text
like: «Due to the Fedora limitations on patents covering some popular formats,
idjc Fedora package is restricted to support OGG, FLAC, SPEEX formats. Support
of MP3, WMA is available at upstream sources». 


> Good idea! I could add pulseaudio-module-jack as dependency. It may not be
> necessary for the application to run, but it make the life of a Fedorian much
> more easier if he wishes to integrate it with other Pulseaudio apps.

Fine


> > * Have you considered to include the html documentation?
> 
> done :)

Good.

Please remove the Makefile* files such they are unnecessary


> > * Should be important to add a Requires: tag for icecast?
> 
> I don't think so. IDJC is just the client. Icecast could be on a different
> machine. Certainly not a dependency.

perfect


> > Checking list:
> > 
> > * Group: tag is wrong, use Applications/Multimedia

> Being a streaming application I find the Applications/Internet category more
> appropriate.

Well, Icecast itself has been tagged «Applications/Multimedia» in Fedora. Check
for yourself:
http://pkgs.fedoraproject.org/gitweb/?p=icecast.git;a=blob_plain;f=icecast.spec;hb=b4d27c3ef96f50ad07499fcc909a345489a2b436
 :-)

please fix

> > 
> > * the idjc.desktop file should include at least the AudioVideo category

please fix this too; add any other category if needed at your consideration


> > * Why you remove the Application category from idjc.desktop?
> 
> What Christoph said. It's no longer a valid category.

fine


Please fix the mentioned issues. The proposal is almost ready.


> > PD: Completely out of this review, maybe you'll like to contrib a full featured idjc to RPM Fusion (something like idjc-freeworld)
> 
> Yeap. I plan to do so :)

Great!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.