[Bug 743615] Review Request: nagios-plugins-openmanage - Nagios plugin to monitor hardware health on Dell servers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=743615

--- Comment #7 from Trond H. Amundsen <t.h.amundsen at usit.uio.no> 2011-11-28 09:39:14 EST ---
(In reply to comment #6)

> NEEDSWORK:
> - files:
>   * %dir %{_sysconfdir}/nagios double owned:
>     rpm -qf /etc/nagios
>     nagios-3.2.3-11.fc16.x86_64
> 
>     This package R nagios-common, which doesn't R nagios, so the directory is
>     unowned. It would be best to add the directory to nagios-common:
>     Added to the list in bug 756839
>     I wouldn't own it here and wait for nagios-common to pick it up...

The installed config file is just an example config with everything commented
out. Also, the config file is optional and most users will probably not use it.
In retrospect it shouldn't live in /etc/nagios as this directory should only
contain actual Nagios config files, not config files for plugins.

In light of this I have removed it from /etc/nagios and only include it as
documentation ("example.conf") instead.

> - pre-build binary:
>  
> https://fedoraproject.org/wiki/Packaging:Guidelines#No_inclusion_of_pre-built_binaries_or_libraries
>   Please delete the check_openmanage.exe binary in %prep, although you don't
>   use them later on.

Done.

Updated spec and SRPM available here:
http://folk.uio.no/trondham/review3/nagios-plugins-openmanage.spec
http://folk.uio.no/trondham/review3/nagios-plugins-openmanage-3.7.3-3.el6.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.