[Bug 719958] Review Request: rubygem-rack-cache - HTTP Caching for Rack

bugzilla at redhat.com bugzilla at redhat.com
Tue Nov 29 04:42:01 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=719958

Mamoru Tasaka <mtasaka at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at fedoraproject.org
               Flag|                            |fedora-review+

--- Comment #7 from Mamoru Tasaka <mtasaka at fedoraproject.org> 2011-11-28 23:42:00 EST ---
Well,

* Description
  - I think the %description section can be expanded to be
    more illustrative, as in "README" file or on the URL.

* Documents
  - I think "README" should be in the main rpm, because it
    says "README".

  - Maybe "CHANGES" can also in the main package

* "gem" command usage
  - I prefert to use "gem -V" (verbose mode), however not a blocker

Apart from these, I see no blocker. (srpm, binary) rpms are clean and can be
correctly installed, and seems to be working.

-----------------------------------------------------------------
    This package (rubygem-rack-cache) is APPROVED by mtasaka
-----------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list