[Bug 749812] Review Request: sugar-fraction-bounce - A game which teaches fractions and estimations

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=749812

Juan Orti Alcaine <j.orti.alcaine at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |j.orti.alcaine at gmail.com

--- Comment #2 from Juan Orti Alcaine <j.orti.alcaine at gmail.com> 2011-11-29 08:27:34 EST ---
Hello, I'm going to informally review your package because I'm not a package
maintainer. I also have submited some packages waiting for review and I'm
looking for sponsor, so it would be great if you can review some of my packages
(#738556 #756445 #756435 #756443)

$ rpmlint *
sugar-fractionbounce.noarch: W: non-standard-group Sugar/Activities
sugar-fractionbounce.src: W: non-standard-group Sugar/Activities
sugar-fractionbounce.spec:6: W: non-standard-group Sugar/Activities
2 packages and 1 specfiles checked; 0 errors, 3 warnings.

- I think the correct group would be:  Amusements/Games
- It's cleaner to have only one BuildRequires per line
- You must use BuildRequires: python-devel  instead of only python
- Remove the slash after %{buildroot} because it's already included
- You can drop the %defattr line

Hope it helps.
Regards :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.