[Bug 596461] Review Request: lzma-sdk - SDK for lzma compression

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=596461

--- Comment #68 from Jason Tibbitts <tibbs at math.uh.edu> 2011-11-29 13:36:19 EST ---
OK, I've already run my checklist so this is about looking for new stuff.

The license issues have been dealt with, and the clarification is included in
the package.

The dependency issue was fixed.

All of the previous rpmlint warnings went away.  However, there are some new
ones:

lzma-sdk.x86_64: W: undefined-non-weak-symbol
  /usr/lib64/liblzmasdk.so.4.6.5 __cxa_pure_virtual
lzma-sdk.x86_64: W: undefined-non-weak-symbol
  /usr/lib64/liblzmasdk.so.4.6.5 vtable for __cxxabiv1::__si_class_type_info
lzma-sdk.x86_64: W: undefined-non-weak-symbol
  /usr/lib64/liblzmasdk.so.4.6.5 vtable for __cxxabiv1::__class_type_info
lzma-sdk.x86_64: W: undefined-non-weak-symbol
  /usr/lib64/liblzmasdk.so.4.6.5 vtable for __cxxabiv1::__vmi_class_type_info
lzma-sdk.x86_64: W: undefined-non-weak-symbol
  /usr/lib64/liblzmasdk.so.4.6.5 typeinfo for char const*
lzma-sdk.x86_64: W: undefined-non-weak-symbol
  /usr/lib64/liblzmasdk.so.4.6.5 typeinfo for int
lzma-sdk.x86_64: W: undefined-non-weak-symbol
  /usr/lib64/liblzmasdk.so.4.6.5 __gxx_personality_v0
lzma-sdk.x86_64: W: undefined-non-weak-symbol
  /usr/lib64/liblzmasdk.so.4.6.5 operator delete(void*)
lzma-sdk.x86_64: W: undefined-non-weak-symbol
  /usr/lib64/liblzmasdk.so.4.6.5 operator new[](unsigned long)
lzma-sdk.x86_64: W: undefined-non-weak-symbol
  /usr/lib64/liblzmasdk.so.4.6.5 __cxa_end_catch
lzma-sdk.x86_64: W: undefined-non-weak-symbol
  /usr/lib64/liblzmasdk.so.4.6.5 __cxa_allocate_exception
lzma-sdk.x86_64: W: undefined-non-weak-symbol
  /usr/lib64/liblzmasdk.so.4.6.5 operator delete[](void*)
lzma-sdk.x86_64: W: undefined-non-weak-symbol
  /usr/lib64/liblzmasdk.so.4.6.5 __cxa_begin_catch
lzma-sdk.x86_64: W: undefined-non-weak-symbol
  /usr/lib64/liblzmasdk.so.4.6.5 __cxa_throw
lzma-sdk.x86_64: W: undefined-non-weak-symbol
  /usr/lib64/liblzmasdk.so.4.6.5 operator new(unsigned long)

I have to admit I don't understand these, especially the "typeinfo for *" ones.
 I'm guessing this needs a link against come C++ standard library, but it's not
clear to me why that didn't happen.  Maybe gcc doesn't do that by default
unless called as g++?  makefile.gcc does specify g++ as the compiler but the
make call in %build specifically overrides that.

lzma-sdk.x86_64: W: unused-direct-shlib-dependency
  /usr/lib64/liblzmasdk.so.4.6.5 linux-vdso.so.1
lzma-sdk.x86_64: W: unused-direct-shlib-dependency
  /usr/lib64/liblzmasdk.so.4.6.5 /lib64/libm.so.6
The first is odd.  The second isn't a big deal, I guess; the makefile
explicitly specifies -lm on the link line.

I'd say everything's OK here except for that bit about gcc versus g++.  Any
ideas there?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.