[Bug 757854] Review Request: kcalc - Scientific calculator

Wed Nov 30 15:17:29 UTC 2011

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=757854

--- Comment #1 from Jaroslav Reznik <jreznik at redhat.com> 2011-11-30 10:17:28 EST ---
Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated

==== C/C++ ====
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Package contains no static executables.

==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported architecture.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Package contains a properly installed %{name}.desktop using desktop-
     file-install file if it is a GUI application.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
     names).
[x]: MUST Package meets the Packaging Guidelines.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.

rpmlint kcalc-debuginfo-4.7.80-1.fc17.i686.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.

rpmlint kcalc-4.7.80-1.fc17.src.rpm

kcalc.src: W: invalid-url Source0:
ftp://ftp.kde.org/pub/kde/stable/4.7.80/src/kcalc-4.7.80.tar.bz2 <urlopen error
ftp error: 550 Failed to change directory.>
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

rpmlint kcalc-4.7.80-1.fc17.i686.rpm

kcalc.i686: E: invalid-soname /usr/lib/libkdeinit4_kcalc.so
libkdeinit4_kcalc.so
kcalc.i686: E: script-without-shebang
/usr/share/applications/kde4/kcalc.desktop

> kcalc.desktop has exec acls

kcalc.i686: W: no-manual-page-for-binary kcalc
1 packages and 0 specfiles checked; 2 errors, 1 warnings.

[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
/home/jreznik/test/757854/kcalc-4.7.80.tar.bz2 :
  MD5SUM this package     : 13206383afdbfcabde4c1e47ce2764c0
  MD5SUM upstream package : 13206383afdbfcabde4c1e47ce2764c0

[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
     /usr/sbin.
[x]: SHOULD Package functions as described.
[x]: SHOULD Package does not include license text files separate from
     upstream.
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD Package should compile and build into binary rpms on all supported
     architectures.
[x]: SHOULD Spec use %global instead of %define.

Issues:
[!]: MUST Rpmlint output is silent.

rpmlint kcalc-debuginfo-4.7.80-1.fc17.i686.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.

rpmlint kcalc-4.7.80-1.fc17.src.rpm

kcalc.src: W: invalid-url Source0:
ftp://ftp.kde.org/pub/kde/stable/4.7.80/src/kcalc-4.7.80.tar.bz2 <urlopen error
ftp error: 550 Failed to change directory.>
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

> Just fix to unstable for now.

rpmlint kcalc-4.7.80-1.fc17.i686.rpm

kcalc.i686: E: invalid-soname /usr/lib/libkdeinit4_kcalc.so
libkdeinit4_kcalc.so
kcalc.i686: E: script-without-shebang
/usr/share/applications/kde4/kcalc.desktop
kcalc.i686: W: no-manual-page-for-binary kcalc
1 packages and 0 specfiles checked; 2 errors, 1 warnings.

> Ok as stated above.

Generated by fedora-review 0.1.1
External plugins:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.