[Bug 698405] Review Request: mcollective - A framework to build server orchestration or parallel job execution systems

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=698405

Steve Traylen <steve.traylen at cern.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |steve.traylen at cern.ch

--- Comment #5 from Steve Traylen <steve.traylen at cern.ch> 2011-11-30 18:38:29 EST ---

All points above look to be fixed, thanks.

The SPEC file just does a unpack and copy things in to the correct place
so the review is pretty simple.

A build and rpmlint shows

./mcollective.spec:179: E: files-attr-not-set

if you really plan to target EPEL5 this should be added back.

More significant:

mcollective.noarch: E: non-readable /etc/mcollective/server.cfg 0440L
mcollective.noarch: W: service-default-enabled /etc/rc.d/init.d/mcollective
mcollective.noarch: W: service-default-enabled /etc/rc.d/init.d/mcollective
mcollective-client.noarch: W: conffile-without-noreplace-flag
/etc/mcollective/rpc-help.erb

Checking quickly all of these they can and should be fixed.

This is other wise looking fairly good, licensing all looks fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.