[Bug 652971] Review Request: code-editor - A text/code editor based on Qt Creator

bugzilla at redhat.com bugzilla at redhat.com
Sat Oct 1 19:47:03 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=652971

--- Comment #46 from Michael Schwendt <mschwendt at gmail.com> 2011-10-01 15:47:01 EDT ---
* If you filter the Requires/Provides, you could also filter out the
non-versioned library names, because those are also private to code-editor.

* Filtering on just ".so.1$" is unsafe. It currently drops the libgcc_s.so.1
dependency. The hardcoded ".1" may cause problems if code-editor's plugin lib
version is changed to .2 or higher. Then more valid dependencies would be
filtered out, such as libdl.so.2. Qt's libs are .4, C/C++ stdlib is .6, for
example.

For filtering Provides, you could ignore the entire plugins directory by using
%filter_provides_in.

For filtering Requires, a logical OR list of the library base names would work,
such as a regexp based on: libAggregation | libCore | libCppTools | ...

If the list of plugin libs changes frequently during upgrades, you could add a
guard somewhere in %install or %check section, where to terminate the build if
the filter_from_requires regexp needed an update.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list