[Bug 712567] Review Request: gnome-shell-theme-ambiance - the ambiance gnome-shell theme

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712567

Mario Blättermann <mariobl at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mariobl at freenet.de
         AssignedTo|nobody at fedoraproject.org    |mariobl at freenet.de
               Flag|                            |fedora-review?

--- Comment #8 from Mario Blättermann <mariobl at freenet.de> 2011-10-02 13:57:12 EDT ---
Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3397410

$ rpmlint -i -v *gnome-shell-theme-ambiance.src: I: checking
gnome-shell-theme-ambiance.src: I: checking-url
http://half-left.deviantart.com/art/GNOME-Shell-Ubuntu-Ambience-210264151
(timeout 10 seconds)
gnome-shell-theme-ambiance.src: I: checking-url
http://www.deviantart.com/download/210264151/gnome_shell___ubuntu_ambiance_by_half_left-d3h6ouv.zip
(timeout 10 seconds)
gnome-shell-theme-ambiance.src: W: uncompressed-zip
gnome_shell___ubuntu_ambiance_by_half_left-d3h6ouv.zip
The zip file is not compressed.

gnome-shell-theme-ambiance.noarch: I: checking
gnome-shell-theme-ambiance.noarch: W: incoherent-version-in-changelog 1.0
['1.0-1.fc17', '1.0-1']
The latest entry in %changelog contains a version identifier that is not
coherent with the epoch:version-release tuple of the package.

gnome-shell-theme-ambiance.noarch: I: checking-url
http://half-left.deviantart.com/art/GNOME-Shell-Ubuntu-Ambience-210264151
(timeout 10 seconds)
gnome-shell-theme-ambiance.spec: I: checking-url
http://www.deviantart.com/download/210264151/gnome_shell___ubuntu_ambiance_by_half_left-d3h6ouv.zip
(timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 2 warnings.


Some issues:

The changelog entry needs to be tagged with the current version number, "1.0-1"
instead of "1.0". In general, you have to screw up the version number in your
spec after any change you made. Currently, we are actually at version 1.0-2.

The Zip file which contains the primary source is unzipped. Well, this is
handled correctly during the build process. As far as I can see, there's no
other source package available. Could be ignored.

There's a typo in a comment line in your spec, "tradmark" instead of
"trademark".

You should add the -p switch to the copy command to keep time stamps.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.