[Bug 696249] Review Request: kupfer - an interface for quick and convenient access to applications and their documents.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=696249

--- Comment #19 from Mario Blättermann <mariobl at freenet.de> 2011-10-02 14:50:31 EDT ---
Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3397561

$ rpmlint -i -v *
kupfer.src: I: checking
kupfer.src: I: checking-url http://kaizer.se/wiki/kupfer/ (timeout 10 seconds)
kupfer.src: W: patch-not-applied Patch0:
%{name}-fix_non-opening_preferences.patch
A patch is included in your package but was not applied. Refer to the patches
documentation to see what's wrong.

kupfer.src: I: checking-url
http://kaizer.se/publicfiles/kupfer/kupfer-v206.tar.gz (timeout 10 seconds)
kupfer.i686: I: checking
kupfer.i686: I: checking-url http://kaizer.se/wiki/kupfer/ (timeout 10 seconds)
kupfer.i686: E: no-binary
The package should be of the noarch architecture because it doesn't contain
any binaries.

kupfer.i686: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.

kupfer.i686: E: standard-dir-owned-by-package /usr/bin
This package owns a directory that is part of the standard hierarchy, which
can lead to default directory permissions or ownerships being changed to
something non-standard.

kupfer.x86_64: I: checking
kupfer.x86_64: I: checking-url http://kaizer.se/wiki/kupfer/ (timeout 10
seconds)
kupfer.x86_64: E: no-binary
The package should be of the noarch architecture because it doesn't contain
any binaries.

kupfer.x86_64: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.

kupfer.x86_64: E: standard-dir-owned-by-package /usr/bin
This package owns a directory that is part of the standard hierarchy, which
can lead to default directory permissions or ownerships being changed to
something non-standard.

kupfer-debuginfo.i686: I: checking
kupfer-debuginfo.i686: I: checking-url http://kaizer.se/wiki/kupfer/ (timeout
10 seconds)
kupfer-debuginfo.i686: E: empty-debuginfo-package
This debuginfo package contains no files.  This is often a sign of binaries
being unexpectedly stripped too early during the build, rpmbuild not being
able to strip the binaries, the package actually being a noarch one but
erratically packaged as arch dependent, or something else.  Verify what the
case is, and if there's no way to produce useful debuginfo out of it, disable
creation of the debuginfo package.

kupfer-debuginfo.x86_64: I: checking
kupfer-debuginfo.x86_64: I: checking-url http://kaizer.se/wiki/kupfer/ (timeout
10 seconds)
kupfer-debuginfo.x86_64: E: empty-debuginfo-package
This debuginfo package contains no files.  This is often a sign of binaries
being unexpectedly stripped too early during the build, rpmbuild not being
able to strip the binaries, the package actually being a noarch one but
erratically packaged as arch dependent, or something else.  Verify what the
case is, and if there's no way to produce useful debuginfo out of it, disable
creation of the debuginfo package.

kupfer-plugins.i686: I: checking
kupfer-plugins.i686: I: checking-url http://kaizer.se/wiki/kupfer/ (timeout 10
seconds)
kupfer-plugins.i686: W: dangling-relative-symlink
/usr/share/Thunar/sendto/kupfer.desktop ../../applications/kupfer.desktop
The target of the symbolic link does not exist within this package or its file
based dependencies.  Verify spelling of the link target and that the target is
included in a package in this package's dependency chain.

kupfer-plugins.x86_64: I: checking
kupfer-plugins.x86_64: I: checking-url http://kaizer.se/wiki/kupfer/ (timeout
10 seconds)
kupfer-plugins.x86_64: W: dangling-relative-symlink
/usr/share/Thunar/sendto/kupfer.desktop ../../applications/kupfer.desktop
The target of the symbolic link does not exist within this package or its file
based dependencies.  Verify spelling of the link target and that the target is
included in a package in this package's dependency chain.

kupfer.spec: W: patch-not-applied Patch0:
%{name}-fix_non-opening_preferences.patch
A patch is included in your package but was not applied. Refer to the patches
documentation to see what's wrong.

kupfer.spec: I: checking-url
http://kaizer.se/publicfiles/kupfer/kupfer-v206.tar.gz (timeout 10 seconds)
7 packages and 1 specfiles checked; 6 errors, 6 warnings.


Some more issues:

The package should be noarch, because no binary file is present anywhere. This
explains why the debuginfo packages are empty.

The nautilus extension is in /usr/lib, that's OK so far, but it should also go
into a subpackage.

Please change %{_bindir} to %{_bindir}/* to let only the executable files be
owned by your package, not the folder itself.

You may remove the %defattr line from the file lists, unless you want to
provide your package for EPEL <= 5.

The Patch0 is nowhere applied. You have to apply it in the %prep section:
%patch0 -p0

Please move the Thunar file into its own subpackage, as earlier mentioned.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.