[Bug 678809] Review Request: seeks - A web-search proxy that provides a meta-search engine

bugzilla at redhat.com bugzilla at redhat.com
Sun Oct 2 22:06:17 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=678809

--- Comment #7 from Mohamed El Morabity <pikachu.2014 at gmail.com> 2011-10-02 18:06:15 EDT ---
I provides above a patch to fix compilation issues with OpenCV. It seems latest
versions of OpenCV doesn't provide anymore cxflann.h, replaced by cv.h.

Some comments by the way:

1) About this:
     # Use db2x_docbook2man, not docbook2x-man, to install doc.
     Patch0:         %{name}-%{version}-docbook.patch
     # Change configuration
     Patch1:         %{name}-%{version}-datalogfiles.patch
You should not use version macros in patch references. Keeping the versions
hardwritten here allows you to reuse the patches without renaming, in case of
update, if still valid. By the way, you have a kind of history of your patches
with such a scheme.

2) Having a *-devel package without header is useless and nonsense here. I
probably already told you that when you started working on packaging seeks, but
you must clarify the status of these files with upstream:
- if they are really useful, why the headers providing the API are not
installed?
- if not, they must be removed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list