[Bug 742189] Review Request: rubygem-webmock - Library for stubbing HTTP requests in Ruby

bugzilla at redhat.com bugzilla at redhat.com
Mon Oct 3 15:27:18 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=742189

Vít Ondruch <vondruch at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vondruch at redhat.com

--- Comment #4 from Vít Ondruch <vondruch at redhat.com> 2011-10-03 11:27:17 EDT ---
I have few suggestions:

* Please check duplicated "Requires: rubygem(addressable)"
* Please execute test suite if available upstream.
* I would suggest to move following files into -doc subpackage:

%{geminstdir}/Gemfile
%{geminstdir}/Rakefile
%doc %{geminstdir}/minitest
%doc %{geminstdir}/test
%doc %{geminstdir}/spec
%doc %{geminstdir}/%{gemname}.gemspec
%doc %{geminstdir}/CHANGELOG.md
%doc %{geminstdir}/Guardfile

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list