[Bug 676335] Review Request: dmtcp - Checkpoint/Restart functionality for Linux processes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=676335

--- Comment #30 from Kapil Arya <kapil at ccs.neu.edu> 2011-10-04 16:53:23 EDT ---
Thanks Thomas, for pointing out the differences.

We do realize now that we would need separate spec files for the two distros
and have started working in that direction. 

(In reply to comment #29)
> (In reply to comment #16)
> > I used OpenBuild services by OpenSUSE and the package built fine. Here is the
> > link:
> > https://build.opensuse.org/package/show?package=dmtcp&project=home%3Akarya0
> > 
> > Is there an way to fix this bug?
> 
> There are many differences between opensuse and fedora, so I'm afraid, that it
> won't be easy possible to:
>   * use the OpenBuild service for testing fedora spec files
>   * using the same spec in both distributions
> 
> Some issues:
> - disable-option-tracking results in failure of configure:
>   setting enable_option_checking=no in configure.ac helps here, see comment #1
> - Where do you have the source from?
>   https://fedoraproject.org/wiki/Packaging:SourceURL#Referencing_Source

The latest sources (comment #22) were generated on a fedora 15 virtual machine.
(The earlier ones were generated by OpenBuild service, but now we are
generating in the fedora15 VM).

> - %make_install is way different from the usual "make install
> DESTDIR=%{buildroot}
>   and only should be used as last resort. Please use the "make install ..." 
>   command

Ok.

> - the "static" packages are named e.g. libdmtcpaware-static (without the -devel 
>   in between)

Will take care of this.

> - "# disable the test for now as bash is failing with 32-bit when built on
> 64-bit
>   machine.":

I will go back an recheck this. This used to be true for OpenBuild services,
but since we are not using them any more, I need to confirm this.

> - cp QUICK-START COPYING %{buildroot}/%{_defaultdocdir}/%{name}-%{version}/
>   fails because the directory doesn't exist yet.
>   %doc them in the %files section would be best here (apparently you don't 
>   install docs within %make_install).

Will fix it as well.

> - Requireing should be done with %{_isa} (also the devel packages etc):
>   https://fedoraproject.org/wiki/PackagingGuidelines#Requiring_Base_Package

Thanks for the pointer. I will make these changes and those suggested by Neal
and put a pointer to the updated RPM and SPEC file here.

Thanks,
-Kapil

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.