[Bug 711893] Review Request: rubygem-dnsruby - Ruby DNS(SEC) implementation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711893

--- Comment #10 from Vít Ondruch <vondruch at redhat.com> 2011-10-05 02:01:41 EDT ---
(In reply to comment #7)
> - I left the %check commented because it requires network connectivity,
> contains errors and missing check targets, and actually hangs.

I agree that test suite could be left disabled, when it requires some network
traffic, but if you are testing locally and it hangs, then it is bad sign and
should be better evaluated. You are preventing problems not just yourself but
also to your users.

> - I install using --no-ri to avoid the above mentioned file name issues

Please no, don't do that. This is how RI works. Just ignore the output, that's
it. Rpmlint provides just hints, rpmlints with 0 warnings is not must.


> - I added this to the %files (do these belong in a rubygem package?)
>   %{geminstdir}/test
>   %{geminstdir}/demo
>   %{geminstdir}/Rakefile

These should be typically contained in -doc subpackage.

> - Added %doc %{geminstdir}/README to base package (as well as doc package)

There is no need to include the README into both packages, since the -doc
subpackage has explicit require for base package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.