[Bug 743615] Review Request: nagios-plugins-openmanage - Nagios plugin to monitor hardware health on Dell servers
bugzilla at redhat.com
bugzilla at redhat.com
Wed Oct 5 16:34:25 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=743615
Terje Røsten <terjeros at phys.ntnu.no> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |terjeros at phys.ntnu.no
--- Comment #1 from Terje Røsten <terjeros at phys.ntnu.no> 2011-10-05 12:34:23 EDT ---
# No binaries here, do not build a debuginfo package
%global debug_package %{nil}
Why is not use BuildArch: noarch?
URL: http://folk.uio.no/trondham/software/%{plugin}.html
Source0:
http://folk.uio.no/trondham/software/files/%{plugin}-%{version}.tar.gz
I don't see the value in using the %{plugin} macro here.
BuildRequires: /usr/bin/pod2man
Well, simply using BuildRequires: perl should be safe and faster?
Requires: perl(Config::Tiny)
Requires: perl(Net::SNMP)
Requires: perl(Crypt::Rijndael)
Please let rpm find these.
You will find this page useful:
http://fedoraproject.org/wiki/Packaging:Perl
Provides: nagios-plugins-check-openmanage = %{version}-%{release}
Obsoletes: nagios-plugins-check-openmanage < 3.7.2-3
Please explain the need for these lines.
%{nagiospluginsdir}/*
%{_mandir}/man8/*.8*
%{_mandir}/man5/*.5*
%dir %{_sysconfdir}/nagios
%config(noreplace) %{_sysconfdir}/nagios/*
1)I like more explicit file list, however that's me.
2) I guess %dir %{_sysconfdir}/nagios is owned by nagios-plugins
and not needed in this package?
Would be nice if you could create a FAS account and do a koji scratch build.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list