[Bug 702143] Review Request: wallaby - configuration service for Condor pools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=702143

--- Comment #7 from Tom "spot" Callaway <tcallawa at redhat.com> 2011-10-06 13:49:48 EDT ---
rpmlint output:

wallaby.src: W: file-size-mismatch wallaby-0.10.6.tar.gz = 532480,
https://fedorahosted.org/releases/g/r/grid/wallaby-0.10.6.tar.gz = 347590

Sure enough, the sizes and sums do not match:
3f18b05e52dbb7af1f6e4c40cefea2d50d162af732897bc7057bb21bd2199841 
wallaby-0.10.6.tar.gz
4175e82e705eafe07d41ccdc58a04fd27890b9dfaadc2e01420971264a17341c 
rpmbuild/SOURCES/wallaby-0.10.6.tar.gz

Please resolve that. :)

wallaby.noarch: W: non-standard-uid /var/lib/wallaby wallaby
wallaby.noarch: W: non-standard-gid /var/lib/wallaby wallaby
wallaby.noarch: W: non-standard-uid /var/log/wallaby wallaby
wallaby.noarch: W: non-standard-gid /var/log/wallaby wallaby

Safe to ignore.

wallaby.noarch: E: script-without-shebang /lib/systemd/system/wallaby.service

This is happening because of this line in the -wallaby files section:

%defattr(0755,root,root,-)

It should go away if you add a defattr reset line directly above 

%{_unitdir}/wallaby.service

So that the section will look like:

...
%defattr(0755,root,root,-)
%{_bindir}/wallaby-agent
%if %{want_systemd}
%defattr(-,root,root,-)
%{_unitdir}/wallaby.service
%else
%{_initrddir}/wallaby
%endif

systemd service files do not need to be chmod +x (as opposed to old sysvinit
files which do).

wallaby.noarch: W: no-manual-page-for-binary wallaby-agent
wallaby-utils.noarch: W: no-manual-page-for-binary wallaby

Safe to ignore for packaging purposes, but still recommended to do as a best
practice for providing documentation.

ruby-wallaby.noarch: W: no-documentation
wallaby-python.noarch: W: no-documentation
wallaby-http-server.noarch: W: no-documentation

All safe to ignore.

***
Fix those last minor items and I think this one is done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.