[Bug 713313] Review Request: msktutil - Program for interoperability with Active Directory

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713313

--- Comment #12 from Volker Fröhlich <volker27 at gmx.at> 2011-10-06 17:01:33 EDT ---
I noticed, your basically packaging the head revision now.

You could consider this a post-release snapshot, as described here:
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages

If you switch to packaging a snapshot, you're loosing 3 patches and I think
it's also clearer to the user.

Small remark: I think you can simplify the if clauses:

%if (0%{?fedora} && 0%{?fedora} <= 15) || (0%{?rhel} && 0%{?rhel} <= 6)

-->

%if (0%{?fedora} <= 15) || 0%{?rhel} <= 6)

Let me know about the snapshot thing, then I'll do the formal review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.