[Bug 743370] Review Request: libsmartpen - Library for communicating with the Livescribe Pulse Smartpen

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=743370

--- Comment #4 from Thomas Spura <tomspur at fedoraproject.org> 2011-10-06 18:09:41 EDT ---
(In reply to comment #3)
> Upstream is in git and have released a few versions. However they don't build
> cleanly due to hardcoded paths in their Makefile. So I forked their git repo
> (github) and generated my own tarball that includes the patches I've made...
> How should this be packaged? take their tarball and using git history apply a
> bunch of patches until upstream includes them? Or just use my git fork pulling
> in new versions as they make them??

You guess you need to use upstream tarball (or a git checkout) and do your
patches on top of that.
Having your own git repository only helps with upstreaming patches and keeping
track of your changes.

Using your repository as source would be a fork of upstream and not the real
upstream source.
(I think this would be a blocker)

> Spec URL: http://www.gnat.ca/libsmartpen.spec
> SRPM URL: http://www.gnat.ca/libsmartpen-0.6-2.src.rpm
> 
> the sitelib0 was me copying from func.spec which has them conditionally defined
> but what I wanted was python_sitearch and didn't know they were provided by
> python-devel so just made up my own. I should have checked the guidelines
> instead of another spec I guess.

Thanks for changing it.

Further comments:
- BR and R of python is not needed. BR: python-devel is enought, the rest
happens automatically.
- please delete the --prefix on installing, or is it absolutely needed?
- beeing a bit more expilcit in %files would be great, e.g. the
subdirectories/files of %{python_sitearch} should be there, so python egg
failures are detected.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.