[Bug 554464] Review Request: python-pebl - Python Environment for Bayesian Learning

bugzilla at redhat.com bugzilla at redhat.com
Sun Oct 9 10:21:45 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=554464

--- Comment #16 from Thomas Spura <tomspur at fedoraproject.org> 2011-10-09 06:21:43 EDT ---
(In reply to comment #15)
> I applied the Toshio's patch to fix most of the warnings when building the
> Sphinx documentation.
OK
> I put a new version of the .spec file and .src.rpm to
> http://tadej.fedorapeople.org/.

Can you please provide SPEC/SRPM links like in comment #0 next time?
Thanks.

> I also did a scratch build of the package in koji and the results are here:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=3414470
OK

I get more rpmlint outputs:
$ rpmlint ~/rpmbuild/SRPMS/python-pebl-1.0.2-5.fc15.src.rpm
~/rpmbuild/RPMS/x86_64/python-pebl-*
python-pebl.src: W: spelling-error %description -l en_US interventional ->
intervention, international, Internationale
python-pebl.src: W: invalid-url Source0:
http://pebl-project.googlecode.com/files/pebl-1.0.2.tar.gz HTTP Error 404: Not
Found
python-pebl.x86_64: E: explicit-lib-dependency python-matplotlib
python-pebl.x86_64: W: spelling-error %description -l en_US interventional ->
intervention, international, Internationale
python-pebl.x86_64: W: no-manual-page-for-binary pebl
3 packages and 0 specfiles checked; 1 errors, 4 warnings.

But all ignoreable/false positives.
e.g. spectool works, so the link to the source is good.

- Disabling the internal dependency generator is not needed, when using:
 
https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Arch-specific_extensions_to_scripting_languages

or:
 
https://fedoraproject.org/wiki/User:Tibbs/AutoProvidesAndRequiresFiltering#RPM_4.9_method_.28Fedora_15_and_newer.29

  (depends, where you want to branch later on)

- For a failing test suite you could append "| :" so at least anything else is
checked for now. (Maybe it will completely work, when you also add the
dependencies)

- ipython1 should be dead, I hope upstream will adopt the new ipython -.-

_____________________________________________

Will approve, when the dependency generator looks fine, test suite is "should".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list